Skip to content

[device][platform] Add to support as7926-40xfb platform (SFP refactor) - #10648

Open
brandonchuang wants to merge 1 commit into
sonic-net:masterfrom
brandonchuang:as7926
Open

[device][platform] Add to support as7926-40xfb platform (SFP refactor)#10648
brandonchuang wants to merge 1 commit into
sonic-net:masterfrom
brandonchuang:as7926

Conversation

@brandonchuang

@brandonchuang brandonchuang commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Brandon Chuang brandon_chuang@edge-core.com

Switch Vendor: Accton
Switch SKU: Accton-AS7926-40XFB
CPU: BROADWELL-DE
ASIC Vendor: Broadcom
Switch ASIC: Broadcom BCM88690
Port Configuration: 40xQSFP28 + 13x QSFP-DD + 2x SFP+

Why I did it

To support as7926-40xfb platform

How I did it

Implement kernel driver and sonic_platform

How to verify it

Test sysfs / sensors cmd / sonic_platform / show platform cmd
show platform firmware status
show platform syseeprom
show platform summary
show platform psustatus
show platform fan
show platform temperature
show system health
psuutil
sfputil
sensors

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

@sujinmkang

sujinmkang commented May 2, 2022

Copy link
Copy Markdown
Collaborator

@brandonchuang Can you please share the show platform ... output and pmon daemon status? And can you also share sonic-mgmt test results if you have run on this platform yet?

@brandonchuang

brandonchuang commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

@brandonchuang Can you please share the show platform ... output and pmon daemon status? And can you also share sonic-mgmt test results if you have run on this platform yet?

Here are the output of show platform *

root@sonic:/home/admin# show platform fan
Drawer LED FAN Speed Direction Presence Status Timestamp

FanTray-1 green FAN-1F 50% exhaust Present OK 20220420 16:03:55
FanTray-1 green FAN-1R 49% exhaust Present OK 20220420 16:03:55
FanTray-2 green FAN-2F 50% exhaust Present OK 20220420 16:03:55
FanTray-2 green FAN-2R 49% exhaust Present OK 20220420 16:03:55
FanTray-3 green FAN-3F 49% exhaust Present OK 20220420 16:03:55
FanTray-3 green FAN-3R 50% exhaust Present OK 20220420 16:03:55
FanTray-4 green FAN-4F 50% exhaust Present OK 20220420 16:03:55
FanTray-4 green FAN-4R 48% exhaust Present OK 20220420 16:03:55
FanTray-5 green FAN-5F 49% exhaust Present OK 20220420 16:03:55
FanTray-5 green FAN-5R 49% exhaust Present OK 20220420 16:03:55
N/A green PSU-1 FAN-1 70% exhaust Present OK 20220420 16:03:55
N/A green PSU-2 FAN-1 70% exhaust Present OK 20220420 16:03:55

root@sonic:/home/admin# show platform psustatus
PSU Model Serial HW Rev Voltage (V) Current (A) Power (W) Status LED

PSU 1 PTT1600-12-054NAS445 420002083400600002 N/A 12.01 16.03 192.00 OK green
PSU 2 PTT1600-12-054NAS445 420002083400600027 N/A 0.00 0.00 0.00 NOT OK red

root@sonic:/home/admin# show platform firmware status
Chassis Module Component Version Description

7926-40XKFB-O-AC-F N/A CPLD1 18 CPLD 1
CPLD2 18 CPLD 2
CPLD3 18 CPLD 3
BIOS v45.0a.01.00 Basic Input/Output System

root@sonic:/home/admin# show platform temperature
Sensor Temperature High TH Low TH Crit High TH Crit Low TH Warning Timestamp

PSU-1 temp sensor 1 20.75 N/A N/A N/A N/A False 20220420 16:03:55
PSU-2 temp sensor 1 19.5 N/A N/A N/A N/A False 20220420 16:03:55
Temp sensor 1 21 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 2 29 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 3 29 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 4 22 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 5 18 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 6 19 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 7 21 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 8 17 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 9 24 70.0 N/A N/A N/A False 20220420 16:03:55
Temp sensor 10 23 70.0 N/A N/A N/A False 20220420 16:03:55

root@sonic:/home/admin# show platform syseeprom
TlvInfo Header:
Id String: TlvInfo
Version: 1
Total Length: 180
TLV Name Code Len Value

Product Name 0x21 18 7926-40XKFB-O-AC-F
Part Number 0x22 13 FNP9J7640000A
Serial Number 0x23 12 EC2052000222
Base MAC Address 0x24 6 90:3C:B3:6A:DB:00
Manufacture Date 0x25 19 02/02/2021 08:00:00
Label Revision 0x27 3 R0A
Platform Name 0x28 29 x86_64-accton_as7926_40xfb-r0
ONIE Version 0x29 19 20211025-test-dirty
MAC Addresses 0x2A 2 256
Manufacturer 0x2B 6 Accton
Manufacture Country 0x2C 2 TW
Vendor Name 0x2D 8 Edgecore
Diag Version 0x2E 11 02.01.00.04
CRC-32 0xFE 4 0xB84EB565

root@sonic:/home/admin# show platform summary
Platform: x86_64-accton_as7926_40xfb-r0
HwSKU: Accton-AS7926-40XFB
ASIC: broadcom
ASIC Count: 1
Serial Number: EC2052000222
Model Number: FNP9J7640000A
Hardware Revision: N/A

@brandonchuang

brandonchuang commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

@brandonchuang Can you please share the show platform ... output and pmon daemon status? And can you also share sonic-mgmt test results if you have run on this platform yet?

pmon status:
root@sonic:/home/admin# docker ps -a
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
e2938e9ce50b docker-platform-monitor:latest "/usr/bin/docker_iniâ€Ķ" 12 days ago Up 27 minutes pmon

For sonic-mgmt, I haven't run yet.

@brandonchuang
brandonchuang requested a review from a team as a code owner June 10, 2022 02:01
github-advanced-security[bot]
github-advanced-security AI found potential problems Oct 25, 2022
View reviewed changes

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com

lgtm-com Bot commented Oct 25, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 3754127c99747a78e99cbfc284ee41af0ef1d7cd into 81ee948 - view on LGTM.com

new alerts:

  • 2 for Comparison using is when operands support `__eq__`

@brandonchuang
[device][platform] Add to support as7926-40xfb platform (SFP refactor)
7bc9e86 
Switch Vendor: Accton
Switch SKU: Accton-AS7926-40XFB
CPU: BROADWELL-DE
ASIC Vendor: Broadcom
Switch ASIC: Broadcom BCM88690
Port Configuration: 40xQSFP28 + 13x QSFP-DD + 2x SFP+

Why I did it
    To support as7926-40xfb platform

How I did it
    Implement sysfs and sonic_platform

How to verify it
    Test sysfs / sensors cmd / sonic_platform / show platform cmd
    show platform firmware status
    show platform syseeprom
    show platform summary
    show platform psustatus
    show platform fan
    show platform temperature
    show system health
    psuutil
    sfputil
    sensors

Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
@lguohan lguohan added the device label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sujinmkang sujinmkang Awaiting requested review from sujinmkang
@prgeor prgeor Awaiting requested review from prgeor
@vdahiya12 vdahiya12 Awaiting requested review from vdahiya12
@lguohan lguohan Awaiting requested review from lguohan

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

device

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandonchuang @sujinmkang @github-advanced-security @lguohan