Repository navigation
Proposed ECMP Next Hop CLI Show Cmd Output Format - #659
Conversation
There was a problem hiding this comment.
This supports a fg-nhg-group-name argument as listed in above section?
There was a problem hiding this comment.
How about 88, 89, 102, 103 without the array like syntax and without single quotes?
There was a problem hiding this comment.
A sorted set of integer values for 'Hash Bucket #' may be better
There was a problem hiding this comment.
Can we also add details about cli output for 'show fg nhg group'?
There was a problem hiding this comment.
Recommend changing Bank Ids to Hash buckets and NIT: Active Next Hops to Next Hop
There was a problem hiding this comment.
Ok will adjust both PRs accordingly
There was a problem hiding this comment.
Please can we update the rev number here to the latest 1.3.
|
Why does it appear that the whole file was modified, hope we can correct that since it helps with maintaining version history. |
1) show ecmp fg-nhg-active-hops <fg-nhg-group-name> 2) show ecmp fg-nhg-hash-view <fg-nhg-group-name> Also have added description about <fg-nhg-group-name> param
65d7028 to
56af004
Compare
Merge conflict between Rev1.2 and Rev1.3 also resolved
| ### 2.3.1 CLI 'show fgnhg hash-view <fg-nhg-group-name>' Output Format | ||
| ``` | ||
|
|
||
| NOTE: <fg-nhg-group-name> is an optional parameter containing the user-defined alias of nhg ipv4 or nhg ipv6 |
There was a problem hiding this comment.
Suggest that we reword this to say NOTE: <fg-nhg-group-name> is an optional parameter containing the user-defined alias defined via FG_NHG entry
| ``` | ||
|
|
||
| Show CLI commands of ```show fg nhg hash-view``` and ```show fg nhg active-hops``` are implemented as a view of the state db table described in section 2.2 | ||
| ### 2.3.1 CLI 'show fgnhg hash-view <fg-nhg-group-name>' Output Format |
There was a problem hiding this comment.
This does not show up as expected when viewed as markdown in the reader, maybe a markdown syntax issue, can you please fix the same
There was a problem hiding this comment.
Addressed and made some more changes within section description
Minor edit to section description as well
|
please add details in description |
Adding CLI command formats for
show fgnhg hash-view
show fgnhg active-hops